fix(form): harden AirForm CSRF validation - #1163
Merged
Merged
Conversation
Validate browser source origins before accepting signed AirForm tokens and require 32-byte process-global secrets. Co-authored-by: Audrey M. Roy Greenfeld <audrey@feldroy.com> Signed-off-by: Audrey M. Roy Greenfeld <audrey@feldroy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originheader, with same-originRefererfallbackRoot cause and impact
AirForm tokens authenticated only a timestamp and nonce with a process-global key. A token obtained by one browser client could therefore be replayed from another origin in a victim client carrying ambient credentials. The request boundary now validates the browser-controlled source origin in addition to the token signature.
Verification
.venv/bin/pytest— 813 passed.venv/bin/ruff format --check .— passed.venv/bin/ruff check .— passed.venv/bin/ty check .— passedgit diff --check— passedRegression coverage includes cross-client token replay, exact origin and Referer matching, default and non-default ports, hostname-suffix tricks, null/missing/duplicate origins, userinfo, weak and empty secrets, secret rotation, and oversized/non-text tokens.